Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate use of CSS text-transform: uppercase #1587

Closed
heartsucker opened this issue Feb 18, 2017 · 7 comments · Fixed by #6362
Closed

Deprecate use of CSS text-transform: uppercase #1587

heartsucker opened this issue Feb 18, 2017 · 7 comments · Fixed by #6362
Labels
i18n Anything related to translation or internationalization of SecureDrop UX

Comments

@heartsucker
Copy link
Contributor

Pedantic fix to some ugliness I introduced in previous changes.
@heartsucker
Copy link
Contributor Author

heartsucker commented Jul 27, 2017 •
edited
Loading

As a note, since SD is moving toward i18n, this might need to be closed and left unimplemented. I'm not sure if browsers are capitalization-aware in other languages. For example, in German there is no such thing as a capital ß, only SS. It would lead to less oddities and a more consistent user experience if the translators write the string as they would be displayed.

Edit: Spoke too soon. Despite what most internet searches say about this being poorly supported and broken, Mozilla claims to support this quite correctly so long as the <html lang="en-US"> attribute is set. returns to eating breakfast

@redshiftzero redshiftzero added the help wanted Issues we would definitely appreciate volunteer help with label Aug 19, 2017
@heartsucker
Copy link
Contributor Author

This should be a requirement for i18n because we don't want to break all the buttons If we ever switch cases. Also, we don't want to annoy our translators with tedious capitalization fixes.

We'd also need to confirm support for this in Tor Browser.

@heartsucker heartsucker added the i18n Anything related to translation or internationalization of SecureDrop label Sep 18, 2017
@heartsucker
Copy link
Contributor Author

Depends on #2354

@eloquence eloquence mentioned this issue Aug 14, 2019
Merged
eloquence added a commit that referenced this issue Aug 14, 2019
@eloquence
Add .upper class and use it for text transformation to minimize i18n …
0cc9bc7 
…churn

Towards #1587
lev-csouffrant pushed a commit to lev-csouffrant/securedrop that referenced this issue Aug 25, 2019
@eloquence @lev-csouffrant
Add .upper class and use it for text transformation to minimize i18n …
df89e7f 
…churn

Towards freedomofpress#1587
kushaldas pushed a commit that referenced this issue Sep 25, 2019
@eloquence @kushaldas
Add .upper class and use it for text transformation to minimize i18n …
7b821f4 
…churn

Towards #1587
@eloquence eloquence changed the title Use CSS text-transform: uppercase instead of all caps in HTML Deprecate use of CSS text-transform: uppercase or use it consistently Sep 18, 2020
@eloquence eloquence added needs/discussion queued up for discussion at future team meeting. Use judiciously. and removed help wanted Issues we would definitely appreciate volunteer help with labels Sep 18, 2020
@eloquence
Copy link
Member

We are using the .upper class that was added since this issue was filed for some strings. We may in fact want to deprecate using it. The Mozilla localization guidelines state:

The text-transform property is not reliable for some locales; for example, text-transform: uppercase won't work properly with languages such as Irish/Gaelic. For example, App Size in English may be capitalized via text-transform: uppercase to APP SIZE but in Gaelic this would change Meud na h-aplacaid to MEUD NA H-APLACAID which violates the locales orthographic rules, as it ought to be MEUD NA hAPLACAID. In general, localizers should make the decision about capitalization. If you want to display WARNING, add a string with that capitalization, and explain it in the localization note.

I've retitled the issue -- we should either deprecate the use of text-transform: uppercase (my recommendation based on the above) or apply it consistently.

@eloquence eloquence removed the needs/discussion queued up for discussion at future team meeting. Use judiciously. label Dec 11, 2020
@eloquence eloquence changed the title Deprecate use of CSS text-transform: uppercase or use it consistently Deprecate use of CSS text-transform: uppercase Dec 11, 2020
@eloquence
Copy link
Member

Retitled per discussion with @conorsch and @rmol, we'll resolve by fully deprecating use of text-transform:uppercase.

@eloquence eloquence mentioned this issue Jun 17, 2021
Closed
@eaon
Copy link
Contributor

eaon commented Feb 17, 2022

Stumbled on this during SI redesign work and confirmed that the only element left which uses text-transform: uppercase is one button in the JI:

securedrop/securedrop/journalist_templates/edit_account.html

Lines 98 to 101 in 7b6c61a

<button type="submit" id="reset-password" class="upper icon icon-reset"
aria-label="{{ gettext('Reset Password') }}">
{{ gettext('Reset Password') }}
</button>

There's a couple of languages which have RESET PASSWORD translated but commented out, is it reasonable to revive those or start fresh?

@cfm
Copy link
Member

cfm commented Feb 18, 2022

Nice catch, @eaon. Are you referring to gettext entries like:

securedrop/securedrop/translations/tr/LC_MESSAGES/messages.po

Lines 1237 to 1238 in 22ed80b

#~ msgid "RESET PASSWORD"
#~ msgstr "PAROLAYI SIFIRLA"

I believe such entries will be reactivated in Weblate as part of the regular i18n_tool.py workflow once that all-caps source string reappears, without our having to uncomment them manually.

eaon added a commit that referenced this issue Mar 23, 2022
@eaon
Remove remaining instances of text-transform: uppercase
211b604 
`text-transform: uppercase` is not compatible with some locales
orthographic rules - we already do it right in almost all places except
one in the JI and a couple other instances where it's actually dead code

Fixes #1587
@eaon eaon mentioned this issue Mar 28, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n Anything related to translation or internationalization of SecureDrop UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove remaining instances of text-transform: uppercase freedomofpress/securedrop
6 participants
@eaon @eloquence @cfm @psivesely @heartsucker @redshiftzero