Readability fixes based on PR review.

freedomofpress · Jan 11, 2022 · d9cd3b2 · d9cd3b2
1 parent 10dd698
commit d9cd3b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/securedrop/journalist_app/col.py b/securedrop/journalist_app/col.py
@@ -138,8 +138,8 @@ def download_single_file(filesystem_id: str, fn: str) -> werkzeug.Response:
                 reply = Reply.query.filter(Reply.filename == fn).one()
                 mark_seen([reply], journalist)
             elif fn.endswith("-doc.gz.gpg") or fn.endswith("doc.zip.gpg"):
-                the_file = Submission.query.filter(Submission.filename == fn).one()
-                mark_seen([the_file], journalist)
+                submitted_file = Submission.query.filter(Submission.filename == fn).one()
+                mark_seen([submitted_file], journalist)
             else:
                 message = Submission.query.filter(Submission.filename == fn).one()
                 mark_seen([message], journalist)

diff --git a/securedrop/store.py b/securedrop/store.py
@@ -332,9 +332,10 @@ def save_file_submission(self,
                              filename: typing.Optional[str],
                              stream: 'IO[bytes]') -> str:
 
-        sanitized_filename = secure_filename("unknown.file")
         if filename is not None:
             sanitized_filename = secure_filename(filename)
+        else:
+            sanitized_filename = secure_filename("unknown.file")
 
         # We store file submissions in a .gz file for two reasons:
         #