Skip to content

Commit

Permalink
Fixes broken ansible-config tests
Browse files Browse the repository at this point in the history
The tests weren't flake8 compliant, which CI did not caught. There were
two separate tests identically named, so one got clobbered and
effectively we weren't testing both required attributes.

The test file now *does* pass flake8, which I confirmed via manual
invocation against it. Opened a separate issue, #2933, to track
improving CI to avoid this problem in the future.
  • Loading branch information
Conor Schaefer committed Jan 25, 2018
1 parent 3025787 commit 87baf3f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion molecule/ansible-config/tests/test_max_fail_percentage.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def test_max_fail_percentage(host, playbook):


@pytest.mark.parametrize('playbook', find_ansible_playbooks())
def test_max_fail_percentage(host, playbook):
def test_any_errors_fatal(host, playbook):
"""
All SecureDrop playbooks should set `any_errors_fatal` to "yes"
on each and every play. In conjunction with `max_fail_percentage` set
Expand Down

0 comments on commit 87baf3f

Please sign in to comment.