Remove "Refresh codename" feature

In practice, this feature has potential for user confusion, as a critical
step of the submission process while delivering minimal end user value.

One key motivation for this feature has been the occasional generation
of problematic words in codenames. We have already iterated over
the wordlists several times, and will continue to do so.

Reloading will also continue to work just fine.

install_files/ansible-base/roles/build-securedrop-app-code-deb-pkg/files/usr.sbin.apache2

@@ -290,7 +290,6 @@
   /var/www/securedrop/static/i/font-awesome/info-circle-black.png r,
   /var/www/securedrop/static/i/font-awesome/lock-black.png r,
   /var/www/securedrop/static/i/font-awesome/refresh-blue.png r,
-  /var/www/securedrop/static/i/font-awesome/refresh-white.png r,
   /var/www/securedrop/static/i/font-awesome/times-white.png r,
   /var/www/securedrop/static/i/font-awesome/white/exclamation-circle.svg r,
   /var/www/securedrop/static/i/font-awesome/white/guard.svg r,

securedrop/sass/source.sass

@@ -276,22 +276,6 @@ p#max-file-size
   margin-bottom: 10px
   margin-top: 5px
 
-#regenerate-submit
-  span
-    font-size: 0
-
-    &:after
-      content: ""
-      display: inline-block
-      background:
-        image: url(/static/i/font-awesome/refresh-white.png)
-        position: center
-        repeat: no-repeat
-        size: contain
-      opacity: 0.9
-      height: 20px
-      width: 20px
-
 #cancel
   &:before
     content: ""
@@ -323,4 +307,4 @@ p#max-file-size
 
     background:
       image: url(/static/icons/chevron-left.png)
-      size: contain
+      size: contain

securedrop/source_app/main.py

@@ -34,7 +34,7 @@ def make_blueprint(config: SDConfig) -> Blueprint:
     def index() -> str:
         return render_template('index.html')
 
-    @view.route('/generate', methods=('GET', 'POST'))
+    @view.route('/generate', methods=('GET',))
     def generate() -> Union[str, werkzeug.Response]:
         if SessionManager.is_user_logged_in(db_session=db.session):
             flash(gettext(

securedrop/source_templates/generate.html

@@ -14,14 +14,6 @@ <h1>{{ gettext('Welcome') }}</h1>
   <h2 id="codename-heading" class="visually-hidden">{{ gettext('Codename') }}</h2>
   <mark id="codename" class="codename"
     aria-describedby="codename-instructions codename-explanation">{{ codename }}</mark>
-  <div class="pull-right">
-    <form id="regenerate-form" method="post">
-      <input name="csrf_token" type="hidden" value="{{ csrf_token() }}">
-      <button type="submit" id="regenerate-submit" class="small">
-        <span>{{ gettext('Refresh codename') }}</span>
-      </button>
-    </form>
-  </div>
 </section>
 
 <p class="explanation">
@@ -38,4 +30,4 @@ <h2 id="codename-heading" class="visually-hidden">{{ gettext('Codename') }}</h2>
     {{ gettext('SUBMIT DOCUMENTS') }}
   </button>
 </form>
-{% endblock %}
+{% endblock %}

securedrop/source_templates/index.html

@@ -108,4 +108,4 @@ <h2 id="return-visit-heading" class="welcome-text">
 
 </body>
 
-</html>
+</html>

securedrop/tests/functional/source_navigation_steps.py

@@ -47,7 +47,7 @@ def _source_clicks_submit_documents_on_homepage(self):
         assert self._is_on_generate_page()
 
     def _source_regenerates_codename(self):
-        self.safe_click_by_id("regenerate-submit")
+        self.driver.refresh()
 
     def _source_chooses_to_submit_documents(self):
         self._source_clicks_submit_documents_on_homepage()

securedrop/tests/functional/test_source.py

@@ -146,7 +146,7 @@ def test_duplicate_generate_pages(self):
 
     def test_refreshed_duplicate_generate_pages(self):
         # Test generation of multiple codenames in different browser tabs, including behavior
-        # of refreshing the codemae in each tab. Ref. issue 4458.
+        # of refreshing the codename in each tab. Ref. issue 4458.
 
         # Generate a codename in Tab A
         assert len(self.driver.window_handles) == 1