Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning for a directory entry using a CDN #576

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Remove warning for a directory entry using a CDN #576

merged 1 commit into from
Dec 21, 2018

Conversation

chigby
Copy link
Contributor

@chigby chigby commented Dec 18, 2018

This pull request removes the no_cdn warning from our warnings collection.

Fixes #573

harrislapiroff
harrislapiroff approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@harrislapiroff harrislapiroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On visual review, looks good 👍🏼✨

@harrislapiroff harrislapiroff merged commit fc48574 into master Dec 21, 2018
@harrislapiroff harrislapiroff deleted the remove-cdn-warning branch December 21, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrislapiroff harrislapiroff harrislapiroff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chigby @harrislapiroff