Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning from no_cookies scan result attribute #547

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

chigby
Copy link
Contributor

@chigby chigby commented Sep 25, 2018

This pull request removes the severe warning attached to a scan result with no_cookies set to True. I originally included it because I misread the spec in #488.

Fixes #544

Note: this requires removing a test against the behavior of multiple
severe warnings, since after removing this warning there is only one
severe-level warning.
@harrislapiroff harrislapiroff force-pushed the 544-remove-cookie-warning branch from 711e9b1 to 25d014e Compare September 25, 2018 23:20
Copy link
Contributor

@harrislapiroff harrislapiroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised 💪💪💪

@harrislapiroff harrislapiroff merged commit 35071bd into master Sep 25, 2018
@harrislapiroff harrislapiroff deleted the 544-remove-cookie-warning branch September 25, 2018 23:31
@conorsch
Copy link
Contributor

Deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants