Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend landing page scanner analytics check beyond Google Analytics #505

Closed
eloquence opened this issue May 25, 2018 · 0 comments
Closed

Extend landing page scanner analytics check beyond Google Analytics #505

eloquence opened this issue May 25, 2018 · 0 comments
Labels
enhancement landing page scanner

Comments

@eloquence
Copy link
Member

eloquence commented May 25, 2018 •
edited
Loading

This is a longer term improvement beyond the scope of the initial scanner integration (#488). Currently the scanner only checks for the presence of Google Analytics (see https://github.com/freedomofpress/securedrop.org/blob/master/scanner/scanner.py#L174). Let's audit the current set of news sites and add any other common analytics scripts we're missing. They would trigger the same severe warning (#496).
eloquence added a commit that referenced this issue Jun 6, 2018
@eloquence
Detect Quantcast, comScore, Chartbeat scripts
18347d4 
Fixes #505. These are the most common analytics scripts on news sites
in the SecureDrop directory.
eloquence added a commit that referenced this issue Jun 6, 2018
@eloquence
Detect Quantcast, comScore, Chartbeat scripts
6a2e38d 
Fixes #505. These are the most common analytics scripts on news sites
in the SecureDrop directory.
@eloquence eloquence mentioned this issue Jun 6, 2018
Merged
3 tasks
harrislapiroff pushed a commit that referenced this issue Jul 10, 2018
@eloquence @harrislapiroff
Detect Quantcast, comScore, Chartbeat scripts
02538fc 
Fixes #505. These are the most common analytics scripts on news sites
in the SecureDrop directory.
eloquence added a commit that referenced this issue Jul 20, 2018
@eloquence
Detect Quantcast, comScore, Chartbeat, Krux scripts
85c192e 
Fixes #505. These are the most common analytics scripts on news sites
in the SecureDrop directory.
eloquence added a commit that referenced this issue Jul 20, 2018
@eloquence
Detect Quantcast, comScore, Chartbeat, Krux scripts
4529a15 
Fixes #505. These are the most common analytics scripts on news sites
in the SecureDrop directory.
eloquence added a commit that referenced this issue Aug 29, 2018
@eloquence
Detect Quantcast, comScore, Chartbeat, Krux scripts
87badf7 
Fixes #505. These are the most common analytics scripts on news sites
in the SecureDrop directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement landing page scanner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eloquence