Add securedrop-workstation-dom0-config 1.0.0 RPM #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also in draft mode until we're ready to release. |
rocodes
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Test plan
- Tag in securedrop-workstation repository is correct: https://github.com/freedomofpress/securedrop-workstation/releases/tag/1.0.0
- Can identically reproduce unsigned RPM
- Build logs are included: freedomofpress/build-logs@b47c0e9
- CI is passing, the rpm is properly signed with the prod key
- Unsigned RPM after running
rpm --delsign(in Fedora 40) on the signed RPM results in the checksum found in the build logs
Reviewed + Approved, waiting to officially approve til later this aft
rocodes
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of package: securedrop-workstation-dom0-config
Refs freedomofpress/securedrop-workstation#1103
Test plan
rpm --delsign(in Fedora 40) on the signed RPM results in the checksum found in the build logs