Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sd-devices test to check for udisks2, not cryptsetup #954

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Feb 22, 2024

Status

Ready for review

Description of Changes

Now that udisks2 is used for locking/unlocking export devices, update sd-devices vm test.
Refs freedomofpress/securedrop-client#1777

Testing

visual review, ci passes. udisks2 is already installed on sd-devices by default, but otherwise this would not be expected to pass until updated packages and their dependencies were installed on the target sdw machine.

Deployment

n/a

Checklist

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0

If you have added or removed files

  • I have updated MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

If documentation is required

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation

@rocodes rocodes requested a review from a team February 22, 2024 19:37
@mig5
Copy link
Contributor

mig5 commented Mar 1, 2024

Nice - just saw this (using the new CI!!) and wondered what it was about :)

@cfm cfm self-assigned this Mar 4, 2024
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! @rocodes, I'll approve but defer to you for merge, given the order of operations before release.

@legoktm legoktm force-pushed the update-sd-devices-tests branch from 4a2f23f to c23ad36 Compare March 12, 2024 21:28
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by sdw-ci :)

@legoktm legoktm merged commit db990ce into freedomofpress:main Mar 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants