-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Qubes OS R4.2 related changes #898
Conversation
Unfortunately GH doesn't support renaming branches without closing the associated PRs. See #897 (comment) for more context |
6468484
to
b127b66
Compare
…d, don't abort on qvm-shutdown failure
On a fresh Qubes 4.2 installation, the initial |
I was trying to use this branch in order to be able to do As we're exploring in #899 that is not entirely the case and there is still relevance for the launcher. So I'd suggest reverting the commit that removed them. |
CONTAINER := $(if $(shell grep "Thirty Two" /etc/fedora-release),,./scripts/container.sh) | ||
# We prefer to use python3.11 if it's availabe, as that is the version shipped | ||
# with Fedora 37, but we're also OK with just python3 if that's all we've got | ||
PYTHON3 := $(if $(shell bash -c "command -v python3.11"), python3.8, python3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PYTHON3 := $(if $(shell bash -c "command -v python3.11"), python3.8, python3) | |
PYTHON3 := $(if $(shell bash -c "command -v python3.11"), python3.11, python3) |
I think the semantics were lost a bit in the change. We want run a version as close as possible to dom0's (python3.11). What the line is currently saying is: if there's python3.11
, run python3.8
.
I cherry-picked commits from this branch (dropping the commits that remove the launcher) into a new one a few days back @deeplow, and started updating there for Qubes 4.2.1 - see https://github.com/freedomofpress/securedrop-workstation/tree/4_2-compat-keep-launcher |
Leaving this PR as draft for now - once the https://github.com/freedomofpress/securedrop-workstation/tree/4_2-compat-keep-launcher branch is mergeable we can cut a new PR and close this one. |
Closing this in favour of #970 |
Description of Changes
Addresses #884. More TK
Testing
TK
Deployment
TK
Checklist
If you have made changes to the provisioning logic
make test
) pass indom0
MANIFEST.in
andrpm-build/SPECS/securedrop-workstation-dom0-config.spec