Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps RPM version 0.5.0-rc1 -> 0.5.0-rc2 #626

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Conversation

conorsch
Copy link
Contributor

Status

Ready for review

Description of Changes

Now that we've merged the template-consolidation PR [0],
we can resume the normal rc build procedure documented in the wiki [1].

[0] #619
[1] https://github.com/freedomofpress/securedrop-workstation/wiki/Building-securedrop-workstation-dom0-config-RPM-package

Testing

Visual review is sufficient. Review the wiki docs on RPM building procedures. The next step is that post-merge, I'll tag, build, and PR an RPM into the yum-test repo.

Checklist

If you have made code changes

  • Linter (make flake8) passes in the development environment (this box may
    be left unchecked, as flake8 also runs in CI)

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0 of a Qubes install

  • This PR adds/removes files, and includes required updates to the packaging
    logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

Now that we've merged the template-consolidation PR [0],
we can resume the normal rc build procedure documented in the wiki [1].

[0] #619
[1] https://github.com/freedomofpress/securedrop-workstation/wiki/Building-securedrop-workstation-dom0-config-RPM-package
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upon visual inspection all lgtm

@sssoleileraaa sssoleileraaa merged commit d538356 into main Oct 28, 2020
@sssoleileraaa sssoleileraaa deleted the sdw-config-0.5.0-rc2 branch October 28, 2020 00:39
@conorsch
Copy link
Contributor Author

Thanks, @creviera! Next step is I'll build and submit an rc2 RPM—likely tomorrow.

cfm pushed a commit that referenced this pull request Apr 1, 2024
Bumps RPM version 0.5.0-rc1 -> 0.5.0-rc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants