Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename securedrop-admin to sdw-admin #596

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Rename securedrop-admin to sdw-admin #596

merged 1 commit into from
Aug 5, 2020

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jul 23, 2020

Status

Ready for review

Description of Changes

Resolves #586. Since securedrop-admin is only provisioned via RPM, no make clean changes should be required.

Test plan

  • Ensure you're running a SecureDrop Workstation staging or prod install created from an RPM.
  • Observe that the securedrop-admin can be successfully run in dom0
  • Check out this PR's branch in your dev env.
  • Bump the RPM version to 0.4.1 as illustrated in the detached commit f24804a (you can use the ./update-version.sh script in the base of this repo)
  • Build a 0.4.1 RPM by running make dom0-rpm and copying that file to dom0.
  • Install the 0.4.1 RPM with sudo dnf install <filename>
  • Observe that securedrop-admin can no longer be run in dom0
  • Observe that you can now access the tool with sdw-admin in dom0
  • Observe that sdw-admin --validate still functions as expected

If you have made code changes

  • Linter (make flake8) passes in the development environment
  • All tests (make test) pass in dom0 of a Qubes install [no impact on test suite]
  • This PR adds/removes files, and includes required updates to the packaging logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

@eloquence
Copy link
Member Author

eloquence commented Jul 24, 2020

Added test plan and successfully stepped through it, declaring this ready to go. This PR bumps the version to 0.4.1 to facilitate update testing. Happy to change this to an RC version string, or to remove the version bump prior to merge (I think changing it to an RC version probably makes sense).

@eloquence
Copy link
Member Author

As discussed in standup this morning, I've removed the version bump commit f24804a from this PR; the reviewer will need to bump the version before building the RPM (updated test plan accordingly).

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@kushaldas kushaldas merged commit 8524398 into main Aug 5, 2020
@eloquence eloquence mentioned this pull request Oct 22, 2020
36 tasks
cfm pushed a commit that referenced this pull request Apr 1, 2024
Rename securedrop-admin to sdw-admin
@legoktm legoktm deleted the 586-sdw-admin branch May 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename securedrop-admin to sdw-admin
2 participants