Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lints updater code for flake8 F523 #551

Merged
merged 1 commit into from
May 12, 2020
Merged

Lints updater code for flake8 F523 #551

merged 1 commit into from
May 12, 2020

Conversation

conorsch
Copy link
Contributor

Status

Ready for review

Description of Changes

F523 is use of str.format without the required a properly structured fmt
string. See https://flake8.pycqa.org/en/latest/user/error-codes.html

Testing

  1. First, reproduce the issue: make flake8 on clean master fails
  2. Then confirm make flake8 on this branch passes

In my testing, technically 2 failed due to the presence of old source dirs for prior versions of the RPM package, which contained older source code. Still, this'll satisfy CI.

Checklist

If you have made code changes

  • Linter (make flake8) passes in the development environment (this box may
    be left unchecked, as flake8 also runs in CI)

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0 of a Qubes install

  • This PR adds/removes files, and includes required updates to the packaging
    logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

F523 is use of str.format without the required a properly structured fmt
string. See https://flake8.pycqa.org/en/latest/user/error-codes.html
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:

  • Reproduced the issue: make flake8 on clean master fails
  • Confirmed make flake8 on this branch passes

@emkll emkll merged commit 391267a into master May 12, 2020
@emkll emkll deleted the flake-linting-f523 branch May 12, 2020 15:01
cfm pushed a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants