Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gnome-disks to sd-devices tests #515

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Mar 27, 2020

Status

Ready for review

Description of Changes

Fixes #511. This PR is mostly to help with review and testing of
freedomofpress/securedrop-export#63 and freedomofpress/securedrop-builder#158

Changes proposed in this pull request:
Adds gnome-disks to sd-devices VMs

Testing

Merging

The following tasks should all be done in one pass, after all 3 PRs have been reviewed/approved:

Checklist

If you have made code changes

  • Linter (make flake8) passes in the development environment (this box may
    be left unchecked, as flake8 also runs in CI)

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0 of a Qubes install

@conorsch
Copy link
Contributor

Local testing shows no problems. I'm going to proceed with dropping the temporary commit, then merging the corresponding PRs in other repos. Small change to the "Merging" instructions: I'm not going to proceed with tag generation. After merging, nightly builds will be added to the test repo, then on Monday we can proceed with final prod package prep. (Already discussed this small change to plan with @emkll out of band, summarizing here for visibility.)

@conorsch conorsch force-pushed the 511-gnome-disks-export branch from df729f6 to 37b56c2 Compare March 28, 2020 00:15
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After preparing local packages as described, test plan checks out:

  • Run make clone
  • make all is successful
  • make test has all tests passing (specifically test_sd_export_package_installed)
  • Running gnome-disks inside sd-devices opens the gnome disk utility

@conorsch conorsch merged commit 8550983 into master Mar 28, 2020
@emkll emkll deleted the 511-gnome-disks-export branch March 30, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install gnome-disk-utility in sd-devices-buster-template
2 participants