Adds gnome-disks to sd-devices tests #515
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #511. This PR is mostly to help with review and testing of
freedomofpress/securedrop-export#63 and freedomofpress/securedrop-builder#158
Changes proposed in this pull request:
Adds gnome-disks to sd-devices VMs
Testing
sd-workstation
folder of this repomake clone
make all
is successfulmake test
has all tests passing (specificallytest_sd_export_package_installed
)gnome-disks
insidesd-devices
opens the gnome disk utilityMerging
The following tasks should all be done in one pass, after all 3 PRs have been reviewed/approved:
securedrop-export
Checklist
If you have made code changes
make flake8
) passes in the development environment (this box maybe left unchecked, as
flake8
also runs in CI)If you have made changes to the provisioning logic
make test
) pass indom0
of a Qubes install