Optimize Fedora Template updates #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In lieu of requiring a workstation reboot, this tradeoff will ensure that reboots are not required every time the workstation is used. The tradeoff is that the network will be temporarily interrupted.
This will ensure the tor circuit is rebuilt and functional after those reboots
Due to the rapid update cycle, we should assume updates are required to reduce the need to start the VM to check for updates
redshiftzero
reviewed
Mar 5, 2020
There was a problem hiding this comment.
I first downgraded salt packages as described in #485 and then ran through the test plan here. All works as advertised and these changes make sense to me. A couple minor comments inline
redshiftzero
approved these changes
Mar 5, 2020
|
Holding off on merge for a bit since @conorsch mentioned he also wanted to take a look at this pre-merge |
|
Nothing to add, diff looks grand, all review comments addressed. 👍 |
9 tasks
15 tasks
cfm
pushed a commit
that referenced
this pull request
Apr 1, 2024
…izations Optimize Fedora Template updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Towards #459
Testing
make cloneandmake prep-dom0~/.securedrop_launcher/sdw-update-statusif required)dnf downgrade zlibinfedora-30to trigger updates)~/.securedrop_launcher/sdw-update-statusChecklist
If you have made code changes
make flake8) passes in the development environment (this box maybe left unchecked, as
flake8also runs in CI)