Fix split logic tests in dev, bump kernel version #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configure-environment script invoked by the Makefile dumps the config to /srv/salt/sd/config.json but does not update the config.json in the source folder in developement environments. Since tests don't currently work against production or starting targets, and are run only in the source repository, let's default to dev values for tests and revisit later.
8 tasks
We're no longer defaulting to prod
conorsch
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Towards #441. Due to the way configure-environment script introduced in #432 only writes the config in /srv/salt and that tests are not shipped as part of staging and prod packages (they need to be checked out in dom0 separately), it seemed acceptable to default to dev values here for tests.
Testing
I think a visual review here is sufficient, as I have already tested the changes locally (make clean, make all, make test, as well as quick client functionality review - download, decrypt, view, export, reply)
devfor tests make senseOptional functional testing