Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still using bash, but pared down the qubesctl calls to what's strictly necessary. Also replaced pkg.upgrade with the Qubes-maintained "update.qubes-vm" Salt state, which intelligently handles Debian/Fedora VMs. It first applies critical patches, such as for DSA-4371-1/CVE-2019-3462, for patching apt, then ensures all packages are up to date.
Ideally we'd leverage the Admin API here, but to aid in review, let's fix the most egregious problems, and go from there.
The major reduction in run time due to these changes is that only the SDW Template VMs are updated, whereas the previous logic used
--templates
to update all TemplateVMs on the host system.Closes #339.
Testing
Confirm no errors, and a reasonable runtime. On my system (T480), the run took ~6m.