Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autostart sd-proxy and sd-gpg at login #255

Merged
merged 2 commits into from
May 16, 2019
Merged

Conversation

emkll
Copy link
Contributor

@emkll emkll commented May 9, 2019

Fixes #200

Test plan:

  • make all on this branch
  • reboot
  • observe sd-gpg and sd-proxy have started without user intervention at boot

Initial client login (after booting of workstation) would fail due to timeout, due to sd-proxy boot time. The initial decryption is also slow, due to the starting of sd-gpg.
@redshiftzero redshiftzero changed the title Autostart sd-proxy and sd-whonix at login Autostart sd-proxy and sd-gpg at login May 9, 2019
@redshiftzero
Copy link
Contributor

Also closes freedomofpress/securedrop-client#181

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Ran make all, rebooted, confirmed that both sd-gpg and sd-proxy had autostarted.

Tacked on some new tests to avoid regressions in the future.

sd-whonix has long been set as autostart, but we didn't have a
corresponding config test for it. We recently enabled autostart
on sd-gpg and sd-proxy, those now also have config tests.

It's a bit anti-Pythonic to `assertTrue(x is True)`, rather than
just `assertTrue(x)`, but trying to be explicit about what the
underlying qubesadmin API returns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set required AppVMs to autostart
4 participants