Switches to upstream python container for linting #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ci-python container was throwing errors related to jessie apt repos. Rather than patch that container, let's switch to an upstream Python 3 container. The 3.5.7 version is not a perfect match for Debian Stretch, which currently uses Pyhton 3.5.3, but it's close enough that it should suffice for linting.
rmol
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ci-python container was throwing errors related to jessie apt repos.
Rather than patch that container, let's switch to an upstream Python 3
container. The 3.5.7 version is not a perfect match for Debian Stretch,
which currently uses Pyhton 3.5.3, but it's close enough that it should
suffice for linting.
Closes #246.
Testing
make flake8on master and confirm failure, similar to errors documented in Linting container is failing in CI #246make flake8on this branch and confirm passing