-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installs mimetype handlers for SVS DispVM via package #201
Conversation
cd3bc32
to
104282c
Compare
We've moved the mimetype file handler logic into a config metapackage, so here we update the Salt logic to remove the hardcoded file, and install the package via the FPF apt repo. Includes some barebones tests to confirm the package is present.
We've already converted the application code to Python 3, but the config tests (run in dom0) were still using Python 2. Fixed.
104282c
to
1f5276d
Compare
Testing mime types:
Checking config tests:
|
Regarding libreoffice, we don't have that installed yet due to a race with the java pax flags. For the others you report as "immediately closes," that sounds like it could be pax flags, as well. For the "immediately closes" apps,
The coverage of filetype handling is something we'll have to continually improve on; if we have pax flags to add, we'll need to store them in the packaging logic and bump releases. |
Ran an sd-svs-disp dispvm, get
and a bunch of "denied RWX mmap"s for totem in journalctl output. |
Totem does indeed require
|
I've uploaded securedrop-workstation-svs-disp 0.1.2 package to apt-test-qubes containing the paxflag update for totem. Totem should now work once the sd-svs-disp-template is updated. I've opened #205 to track progress on LibreOffice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converts the mimetype handler logic for
sd-svs-disp
(used to open submissions) to Debian package, based on logic presented in freedomofpress/securedrop-builder#10.Also updated the config tests to Python 3 because it was easy and closes another issue.
Closes #182. Closes #188.
I'm able to open a test submission (tried a JPG) just fine using the new logic.