Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client integration #194

Merged
merged 8 commits into from
Nov 9, 2018
Merged

Client integration #194

merged 8 commits into from
Nov 9, 2018

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Nov 8, 2018 •
edited
Loading

Close #179

Let's do sd-journalist -> sd-proxy rename in a followup

@emkll emkll force-pushed the client-integration branch 2 times, most recently from 3e4ebd9 to 4dddeaf Compare November 9, 2018 02:06
@emkll
Copy link
Contributor

emkll commented Nov 9, 2018

LGTM, rebased on latest master and fixed securedrop-client dependency name.
I am currently experiencing the issue described in freedomofpress/securedrop-builder#12, but the package is installed and all tests pass.

@redshiftzero redshiftzero changed the title [wip] Client integration Client integration Nov 9, 2018
@redshiftzero
Copy link
Contributor Author

just tested this, working well in sd-svs, confirmed securedrop-client is installed ✅

@redshiftzero
Copy link
Contributor Author

redshiftzero commented Nov 9, 2018 •
edited
Loading

OK on top of the latest debs I can confirm I can sign into a staging server via the client (I hit an error due to a database migration that we forgot in freedomofpress/securedrop-client#114, but I added that in https://github.com/freedomofpress/securedrop-client/pull/129/files which was merged this morning, so tomorrow AM we can do another securedrop-client release with this change

@conorsch
Copy link
Contributor

conorsch commented Nov 9, 2018

Worked for me! That is, I also encountered the app crash after logging in. Error messages were accurate when I provided bad credentials.

@emkll
Update docs to match client-integration branch
dfae906 
* sd-journalist will now be used mostly for securedrop-proxy
* sd-svs will now be used to host the securedrop-client
@redshiftzero
Copy link
Contributor Author

thanks for adding the docs updates @emkll, they LGTM!

@conorsch conorsch mentioned this pull request Nov 9, 2018
Closed
emkll
emkll approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a clean reinstall on this branch, and submissions decrypt successfully in the client 🎉 .

I did, however, experience an error (see image below). This error occurs every time I open the client. One of my sources is encrypted to a different GPG key, which might be the cause. I will validate this assumption and open a ticket.
qfile_error

@redshiftzero
Copy link
Contributor Author

good QA 🥇 , let's open a followup ticket to track this, thanks @emkll

@redshiftzero redshiftzero merged commit 8561ce8 into master Nov 9, 2018
@redshiftzero redshiftzero deleted the client-integration branch November 9, 2018 20:11
@emkll emkll mentioned this pull request Nov 9, 2018
Closed
@emkll emkll mentioned this pull request Jun 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

@conorsch conorsch conorsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redshiftzero @emkll @conorsch