Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecureDrop Workstation 1.0.0-rc3 #1144

Merged
merged 1 commit into from
Jul 10, 2024
Merged

SecureDrop Workstation 1.0.0-rc3 #1144

merged 1 commit into from
Jul 10, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jul 10, 2024

Status

Ready for review

Description of Changes

Refs #1103.

Testing

  • visual review

Deployment

Any special considerations for deployment? n/a

@zenmonkeykstop zenmonkeykstop self-requested a review July 10, 2024 18:48
zenmonkeykstop
zenmonkeykstop previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenmonkeykstop zenmonkeykstop marked this pull request as draft July 10, 2024 19:04
@zenmonkeykstop
Copy link
Contributor

@legoktm #1143 isn't in yet - do you expect it in RC3?

@zenmonkeykstop zenmonkeykstop dismissed their stale review July 10, 2024 19:05

verifying all changes expected are in

@zenmonkeykstop zenmonkeykstop marked this pull request as ready for review July 10, 2024 19:25
zenmonkeykstop
zenmonkeykstop approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of #1143 is landed. LGTM again

@legoktm legoktm merged commit e9fb553 into release/1.0.0 Jul 10, 2024
7 checks passed
@legoktm legoktm deleted the rc3 branch July 10, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenmonkeykstop zenmonkeykstop zenmonkeykstop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legoktm @zenmonkeykstop