Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move securedrop-proxy mimetypes to package #615

Closed
conorsch opened this issue Sep 14, 2020 · 2 comments · Fixed by freedomofpress/securedrop-client#2033
Closed

Move securedrop-proxy mimetypes to package #615

conorsch opened this issue Sep 14, 2020 · 2 comments · Fixed by freedomofpress/securedrop-client#2033
Assignees
@deeplow

Comments

@conorsch
Copy link
Contributor

The mimetype associations added to the sd-proxy VM are currently configured via Salt, not via the securedrop-proxy deb package, or any other package. As we work on template consolidation (#471), we should remove those mimetypes from salt and update the symlink-targeting logic introduced in #605.
@emkll
Copy link
Contributor

emkll commented Sep 14, 2020

Currently, sd-proxy provides a basic Qt window that will be displayed when any file is opened, see: https://github.com/freedomofpress/securedrop-workstation/blob/56c86b1088deb8502ccfcc58b301a138297f59c3/sd-proxy/do-not-open-here

This behavior is what remained from past (pre 0.1.0) iterations, where the workstation relied on users downloading submissions and messages via Tor Browser and opening them manually.

Since we now use the SecureDrop client, to handle file and message management, it might make sense to use the most defensive mimetype handler by default, the same one as sd-app, in other words, opening in a Disposable, non-networked VM by default (openindvm. desktop)

@eloquence eloquence mentioned this issue Sep 16, 2020
Closed
30 tasks
conorsch pushed a commit to freedomofpress/securedrop-apt-test that referenced this issue Oct 2, 2020
Template consolidation: adds sd-viewer package
7ff7a1e 
This package supersedes and replaces the
"securedrop-workstation-sd-svs-disp" package, see
freedomofpress/securedrop-workstation#615
@conorsch conorsch mentioned this issue Oct 2, 2020
Merged
2 tasks
conorsch pushed a commit to freedomofpress/securedrop-apt-test that referenced this issue Oct 6, 2020
Template consolidation: adds sd-viewer package
39f745e 
This package supersedes and replaces the
"securedrop-workstation-sd-svs-disp" package, see
freedomofpress/securedrop-workstation#615
@zenmonkeykstop
Copy link
Contributor

@rocodes to fix.

@legoktm legoktm mentioned this issue Jun 3, 2024
Merged
34 tasks
@legoktm legoktm assigned deeplow and unassigned rocodes Jun 3, 2024
@legoktm legoktm moved this to In Progress in SecureDrop dev cycle Jun 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in SecureDrop dev cycle Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeplow deeplow

Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move MIME handling to systemd services (boot provisioning) freedomofpress/securedrop-client
5 participants
@conorsch @zenmonkeykstop @emkll @rocodes @deeplow