Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF submissions are opened in libreoffice #282

Closed
conorsch opened this issue Jul 11, 2019 · 11 comments · Fixed by #283
Closed

PDF submissions are opened in libreoffice #282

conorsch opened this issue Jul 11, 2019 · 11 comments · Fixed by #283
Labels
bug

Comments

@conorsch
Copy link
Contributor

In what appears to be a regression (see #266), PDF submissions are no longer viewable from the latest client code. Since libreoffice is now present in sd-svs-disp, PDF files are opened in LibreOffice, which is a terrible user experience.

First, let's make sure we have a reliable reproduction of the issue. If so, we should consider fine-tuning the mimetype prefers to prioritize a different application for PDFs, same as we used before the introduction of LibreOffice in #266.
@emkll
Copy link
Contributor

emkll commented Jul 12, 2019

I can reliably reproduce this on latest master

@emkll emkll mentioned this issue Jul 12, 2019
Merged
2 tasks
@eloquence
Copy link
Member

I am seeing this again, at least since the Buster transition w/ December 6 nightlies on Qubes.

@eloquence eloquence reopened this Dec 6, 2019
@conorsch
Copy link
Contributor Author

Likely resolved via #385, marking "needs reproducing." We can close if a test on latest master doesn't show the issue.

@eloquence
Copy link
Member

Screenshot_2020-01-22_16-56-37

Unfortunately this regression is indeed still present in latest nightlies.

@eloquence
Copy link
Member

Per freedomofpress/securedrop-builder#119 securedrop-workstation-svs-disp should be at 0.1.5+buster, but the latest build I see on apt-test-qubes is 0.1.3+buster. Are we just missing a release of this package?

@redshiftzero
Copy link
Contributor

good find, we do not have a nightly build job for securedrop-workstation-svs-disp, we should add it and confirm that this issue is resolved in the latest build

conorsch pushed a commit to freedomofpress/securedrop-builder that referenced this issue Jan 23, 2020
Commits nightly debs for sd-svs-disp package
f8c8815 
We're building the package nightly, but not commiting the package
to the dev lfs repo, so it hasn't landed on developer machines yet.
Identified in freedomofpress/securedrop-workstation#282 (comment)
@conorsch conorsch mentioned this issue Jan 23, 2020
Merged
conorsch pushed a commit to freedomofpress/securedrop-builder that referenced this issue Jan 23, 2020
Builds nightly debs for sd-svs-disp package
62e3358 
We were already building the package on PR runs, but not as nightlies.
Adds a nightly job to changes propagate to the dev lfs repo.
Identified in freedomofpress/securedrop-workstation#282 (comment)
conorsch pushed a commit to freedomofpress/securedrop-builder that referenced this issue Jan 23, 2020
Builds nightly debs for sd-svs-disp package
18f89ea 
We were already building the package on PR runs, but not as nightlies.
Adds a nightly job to changes propagate to the dev lfs repo.
Identified in freedomofpress/securedrop-workstation#282 (comment)
@conorsch
Copy link
Contributor Author

Partial implementation over in freedomofpress/securedrop-builder#131 Confirmed that current behavior on SDW master was still opening PDFs in LibreOffice. After (accidentally) publishing an updated securedrop-workstation-svs-disp, can confirm that the fixes in freedomofpress/securedrop-builder#119 were sufficient: a make all resolves the issue, and PDFs are now opening in Evince as expected.

@eloquence
Copy link
Member

I manually upgraded the package in the template, restarted sd-viewer and the template, and that also resolved it for me 🎉

emkll pushed a commit to freedomofpress/securedrop-builder that referenced this issue Jan 23, 2020
@emkll
Builds nightly debs for sd-svs-disp package
8341025 
We were already building the package on PR runs, but not as nightlies.
Adds a nightly job to changes propagate to the dev lfs repo.
Identified in freedomofpress/securedrop-workstation#282 (comment)
@eloquence
Copy link
Member

Is any follow-up action required on this issue?

@eloquence
Copy link
Member

This is most likely fixed, but I'll re-test before closing.

@conorsch
Copy link
Contributor Author

conorsch commented Feb 5, 2020

Thanks for nudge, @eloquence ; I've tested frequently recently, and can confirm that PDFs are opened in evince again, as we'd expect.

@conorsch conorsch closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install evince in sd-svs-disp-template freedomofpress/securedrop-workstation
4 participants
@eloquence @conorsch @redshiftzero @emkll