Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add salt steps to make sure that the right files have executable bits #173

Closed
kushaldas opened this issue Oct 26, 2018 · 0 comments
Closed
Labels
salt Involves Salt-based configuration management

Comments

@kushaldas
Copy link
Contributor

While working on the RPM packaging of securedrop-workstation I found that rpmbuild is acting too smart, and removing the executable bit from the files as it wishes. Example:

*** WARNING: ./srv/salt/sd/sd-svs/application-x-sd-xfer.xml is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-svs/open-in-dvm.desktop is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-svs/mimeapps.list is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-svs/README is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-svs/decrypt-sd-submission.desktop is executable but has empty or no shebang, removing executable bit
mangling shebang in /srv/salt/sd/sd-svs/decrypt-sd-submission from /usr/bin/env python3 to #!/usr/bin/python3
*** WARNING: ./srv/salt/sd/sd-svs/dot-profile is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-svs/mimeapps-sd-svs-disp.list is executable but has empty or no shebang, removing executable bit
mangling shebang in /srv/salt/sd/sd-journalist/pipereader.py from /usr/bin/env python3 to #!/usr/bin/python3
*** WARNING: ./srv/salt/sd/sd-journalist/mimeapps.list is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-journalist/do-not-open.desktop is executable but has empty or no shebang, removing executable bit
mangling shebang in /srv/salt/sd/sd-journalist/do-not-open-here from /usr/bin/env python3 to #!/usr/bin/python3
*** WARNING: ./srv/salt/sd/sd-journalist/sd-process-download.desktop is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-journalist/sd-process.Feedback is executable but has empty or no shebang, removing executable bit
*** WARNING: ./srv/salt/sd/sd-journalist/sd-process.Feedback-dom0 is executable but has empty or no shebang, removing executable bit
mangling shebang in /srv/salt/sd/sd-journalist/sd-process-download from /usr/bin/env python3 to #!/usr/bin/python3
*** WARNING: ./srv/salt/sd/sd-journalist/sd-process-display is executable but has empty or no shebang, removing executable bit

We should add steps in Salt to make sure that these files are with right executable bits. Also, there are a few scripts with wrong shabang lines.

kushaldas added a commit that referenced this issue Oct 26, 2018
Also updates the .gitignore file for adding spec files.
Before publishing the actual RPM, we will have to fix
#173
kushaldas added a commit that referenced this issue Nov 1, 2018
Also updates the .gitignore file for adding spec files.
Before publishing the actual RPM, we will have to fix
#173
@conorsch conorsch added the salt Involves Salt-based configuration management label Nov 5, 2018
conorsch pushed a commit that referenced this issue Apr 30, 2019
Also updates the .gitignore file for adding spec files.
Before publishing the actual RPM, we will have to fix
#173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
salt Involves Salt-based configuration management
Projects
None yet
Development

No branches or pull requests

2 participants