Add bad data fixture, ensure test doesn't read real release file

freedomofpress · Sep 9, 2020 · fd6b824 · fd6b824
1 parent 29d944d
commit fd6b824
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/launcher/tests/fixtures/bad-os-release-file b/launcher/tests/fixtures/bad-os-release-file
@@ -0,0 +1,4 @@
+# No line
+VERSION=
+[we're doing toml now]
+RELEASES = [ ["gamma", "delta"], [1, 2] ]
diff --git a/launcher/tests/test_util.py b/launcher/tests/test_util.py
@@ -237,6 +237,7 @@ def test_detect_qubes(
         ("os-release-qubes-4.1", 5),
         ("os-release-ubuntu", 4),
         ("no-such-file", 4),
+        ("bad-os-release-file", 4),
     ],
 )
 @mock.patch("Util.sdlog.error")
@@ -283,5 +284,7 @@ def test_pick_bad_qt(
     version via environment override
     """
     mocked_env = {"SDW_UPDATER_QT": env_override}
-    with mock.patch.dict("os.environ", mocked_env), pytest.raises(ValueError):
+    with mock.patch.dict("os.environ", mocked_env), mock.patch(
+        "Util.OS_RELEASE_FILE", os.path.join(FIXTURES_PATH, "os-release-qubes-4.0")
+    ), pytest.raises(ValueError):
         util.get_qt_version()