Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpm import in %post #4

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add rpm import in %post #4

wants to merge 1 commit into from

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Dec 2, 2024

Add rpm key import in boostrap package post. There are 3 cases (clean install, upgrade package, uninstall); cover all of them. In a clean install scenario, import the key to the rpm database. In a package upgrade scenario (key bump), remove the old key and import the key again - this may not be needed if upstream changes are incorporated into a version of rpm available in dom0. In uninstall case, remove the key from the rpm database after the package is uninstalled.

See https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/ for guidelines on scriptlet ordering in upgrade, uninstall, etc.

Fixes freedomofpress/securedrop-workstation#423

Test plan

  • Visual review
  • CI (in draft until CI Add github actions, license file, security.md #6 and rebase)
  • Clean install: build this package with make build-rpm. Package installs successfully; repo file is present in /etc/yum.repos.d and rpm -q gpg-pubkey --qf '%{NAME}-%{VERSION}-%{RELEASE}\t%{SUMMARY}\n' | grep 'SecureDrop Release Signing Key' shows an entry corresponding to our release signing key in the rpm db.
  • Upgrade testing: TODO. This will require an upgrade test plan.

@adaFPF adaFPF marked this pull request as ready for review December 5, 2024 18:18
@adaFPF adaFPF marked this pull request as draft December 5, 2024 18:19
@adaFPF adaFPF marked this pull request as ready for review December 5, 2024 18:19
@adaFPF adaFPF marked this pull request as draft December 5, 2024 18:19
@rocodes rocodes force-pushed the add-rpm-import-postinst branch from 4884830 to 149e29f Compare December 6, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly manage our additions to the rpm keyring instead of appending
1 participant