Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update screenshots, document deletion/seen/unseen #100

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Update screenshots, document deletion/seen/unseen #100

merged 1 commit into from
Feb 2, 2022

Conversation

eloquence
Copy link
Member

Status

Ready for review

Description

Resolves #68
Resovles #61

  • Updates all screenshots to showcase the latest SecureDrop Client (other screenshots are updated for consistency in minor details such as the username shown)
  • Documents "seen/unseen" behavior
  • Documents safe deletion feature
  • Documents journalist reply badges (i.e. the authorship indicators)
  • Makes screenshots clickable to reveal the full size

@rocodes rocodes self-requested a review February 2, 2022 15:01
rocodes
rocodes previously approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM - thanks for doing this, and the clickable screenshots is a really nice touch, we should do this everywhere. :)

@rocodes
Copy link
Contributor

rocodes commented Feb 2, 2022

(Looks like I'm a little slow on the review, and this needs a rebase - I can do it, or you can if you'd like to rebase + re-sign the commit).

@eloquence eloquence force-pushed the 68-screenshots-refresh branch from e15cc31 to dccc4db Compare February 2, 2022 16:16
@eloquence
Copy link
Member Author

Done :) Thanks!

@rocodes rocodes self-requested a review February 2, 2022 21:56
@rocodes rocodes merged commit d68ae5f into main Feb 2, 2022
@eloquence eloquence deleted the 68-screenshots-refresh branch August 24, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocodes rocodes rocodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for read/unread, updated screenshots w/ new source list layout
2 participants
@eloquence @rocodes