Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Use native pytest infrastructure #24

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Use native pytest infrastructure #24

merged 1 commit into from
Feb 14, 2023

Conversation

eaon
Copy link
Contributor

@eaon eaon commented Feb 14, 2023

So far we've relied on deprecated importlib functionality in our tests, as well as our own tmpdir infrastructure. pytest already ships nicer solutions via a tmp_path fixture and dynamic module imports if __init__.py exists in tests/.

Testing

  • CI is happy
  • (Optional) make test is successful when run locally

So far we've relied on deprecated `importlib` functionality in our
tests, as well as our own tmpdir infrastructure. pytest already ships
nicer solutions, which this makes use of now.
@eaon eaon mentioned this pull request Feb 14, 2023
4 tasks
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about the default tmp_path fixture. Nice, glad the importlib stuff is entirely unnecessary.

@legoktm legoktm merged commit bb98fb7 into main Feb 14, 2023
@legoktm legoktm deleted the native-pytest-infra branch February 14, 2023 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants