Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One fix target to rule them all #11

Open
legoktm opened this issue Jul 6, 2023 · 0 comments
Open

One fix target to rule them all #11

legoktm opened this issue Jul 6, 2023 · 0 comments

Comments

@legoktm
Copy link
Member

legoktm commented Jul 6, 2023

We currently have make black and make isort, and soon enough we'll have make ruff. Instead of needing to know which tools are enabled and causing issues, we should have one universal make fix command that runs as many auto-fixers as possible.

In MediaWiki we standardized on composer fix (c.f. https://www.mediawiki.org/wiki/Continuous_integration/Entry_points#PHP), which has worked out nicely IMO.
@legoktm legoktm mentioned this issue Jan 19, 2024
Merged
@legoktm legoktm mentioned this issue May 14, 2024
Merged
@legoktm legoktm mentioned this issue Sep 10, 2024
Merged
legoktm added a commit to freedomofpress/securedrop that referenced this issue Sep 19, 2024
@legoktm
Upgrade ruff, remove black
4badc4c 
Upgrade ruff to the latest version so we can use it for formatting and
native editor integration. While we're at it, introduce the standard
`make fix` target
(<freedomofpress/securedrop-tooling#11>).

Actually fixing new issues will happen in follow-ups to make this change
easier to review.

Fixes #7225.
@legoktm legoktm mentioned this issue Sep 19, 2024
Merged
4 tasks
legoktm added a commit to freedomofpress/securedrop that referenced this issue Sep 19, 2024
@legoktm
Upgrade ruff, remove black
e4a8c7a 
Upgrade ruff to the latest version so we can use it for formatting and
native editor integration. While we're at it, introduce the standard
`make fix` target
(<freedomofpress/securedrop-tooling#11>).

Actually fixing new issues will happen in follow-ups to make this change
easier to review.

Fixes #7226.
legoktm added a commit to freedomofpress/securedrop that referenced this issue Sep 19, 2024
@legoktm
Upgrade ruff, remove black
6770d12 
Upgrade ruff to the latest version so we can use it for formatting and
native editor integration. While we're at it, introduce the standard
`make fix` target
(<freedomofpress/securedrop-tooling#11>).

We can remove `--show-source` too now that it's the default.

Actually fixing new issues will happen in follow-ups to make this change
easier to review.

Fixes #7226.
@jkarasti jkarasti mentioned this issue Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@legoktm