Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

added optional client side uuid selection for replies #49

Merged
merged 3 commits into from
Jan 11, 2019
Merged

added optional client side uuid selection for replies #49

merged 3 commits into from
Jan 11, 2019

Conversation

heartsucker
Copy link
Contributor

@heartsucker heartsucker commented Jan 11, 2019 •
edited
Loading

This is needed for the SDK to be able to set a reply's uuid so a client can track the state of an "in flight" reply in an asynchronous environment.

Related to freedomofpress/securedrop#3957
Blocks freedomofpress/securedrop-client#16

kushaldas
kushaldas suggested changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need test with uuid and without (which is already the default case).

kushaldas
kushaldas approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you @heartsucker. Approved.

@kushaldas kushaldas merged commit 9dffdac into master Jan 11, 2019
@heartsucker heartsucker deleted the reply-uuid branch February 6, 2019 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kushaldas kushaldas kushaldas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heartsucker @kushaldas