This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Updates PyYAML to 5.4.1 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kicking ci |
sssoleileraaa
previously approved these changes
Mar 16, 2021
| @@ -77,3 +77,15 @@ workflows: | |||
| jobs: | |||
| - test-buster | |||
| - build-buster | |||
|
|
|||
| nightly: | |||
| @@ -3,7 +3,7 @@ chardet==3.0.4 --hash=sha256:e5cf39014befb85add77118fdc946f0a3387df7840235ba5d20 | |||
| furl==2.0.0 --hash=sha256:9f50360f6e4a0f1d0a35fb4997878e7186a73331f0fde5f6fc9b1bb9f006e6cc | |||
| idna==2.7 --hash=sha256:a967a752dba5492be34f30f8633cee512d2ec923fe3a2e201d87353b540d2955 | |||
| orderedmultidict==1.0 --hash=sha256:f6022beda2b3387c61e6eb7e0e1e3e2832fd9f55f3f64d4b4b226eea7487327f | |||
| pyyaml==5.3.1 --hash=sha256:ff021f812a5dbaeb10678462952bb447bf6b322ab54923f5591811056a827c15 | |||
| pyyaml==5.4.1 --hash=sha256:c2ab2737721fe6f5545fa830312fe7b77e74932c8bbd780a17a3d7df2ff65f99 | |||
| # via | ||
| # -r dev-requirements.in | ||
| # flake8 | ||
| pyyaml==5.4.1 \ |
There was a problem hiding this comment.
looks like you were able to catch em all: https://pypi.org/project/PyYAML/#files
|
CI failing: |
sssoleileraaa
dismissed
their stale review
moving back to development -- needs to support new pip-tools format of multiline comment in requirements file
emkll
force-pushed
the
update-pyyaml-541
branch
from
a0c91bb to
c1b8e30
Compare
emkll
force-pushed
the
update-pyyaml-541
branch
from
c1b8e30 to
a5da1db
Compare
|
Thanks @creviera , I've reverted to the old pip-tools format for the requirements file to unblock this. I've opened freedomofpress/securedrop-builder#225 to track improvements to the build scripts, which we should tackle in the near future (as we may need to revisit this logic as part of freedomofpress/securedrop-builder#218) This should now be ready for re-review, with CI now passing. |
kushaldas
approved these changes
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes freedomofpress/securedrop-builder#219
This should be reviewed/merged in conjunction with the changes in freedomofpress/securedrop-builder#220 (The build CI target will fail until that PR is merged)
Based on the description of CVE-2020-14343:
We don't use
full_loadof theFullLoader(we only use it to load the configuration viasafe_load) in production, so we shouldn't be vulnerable here. While we should update the version to match the ones use in dev, the changes here will not warrant a proxy release (we can release these updated wheels as part of a future release)