Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Moves config to private volume #79

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Moves config to private volume #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qubes/securedrop.Proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/usr/bin/sd-proxy /etc/sd-proxy.yaml
/usr/bin/sd-proxy /home/user/.securedrop_proxy/sd-proxy.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this path will only exist after running the template consolidation logic [1]. if we do not configure both the existing path and the new path here, the proxy will only work in either the non-consolidated or the consolidated template approach. In other words, this proxy change will break existing installs, until the dom0 logic is run again.

https://github.com/freedomofpress/securedrop-workstation/pull/619/files#diff-6665f59c22d94742e30d7bbf295194ceR7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, this proxy change will break existing installs, until the dom0 logic is run again.

A critical assumption of the template consolidation plan in freedomofpress/securedrop-workstation#619 is that the SecureDrop Workstation components are updated only via the SDW GUI updater. As long as we accept that limitation, then the new updater logic will ensure that the config file is handled appropriately.