Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Updated dependencies to clear safety checks #76

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented Oct 4, 2020

  • updated urllib3 from 1.24.3 to 1.25.10
  • updated requests from 2.20.0 to 2.22.0
  • updated pip-tools to >=5.0.0 to clear pip-related error
  • Updated Makefile to pin pip and setuptools in dev requirements

testing:

- updated urllib3 from 1.25.8 to 1.25.10
- updated pip-tools to >=5.0.0 to clear pip-related error
- Updated Makefile to pin pip and setuptools in dev requirements
@zenmonkeykstop
Copy link
Contributor Author

Yeah.. gonna need to pick someone's brains on dependency updates for this and the client.

@emkll
Copy link
Contributor

emkll commented Oct 5, 2020

CI is failing due to the requirements changes not being present in build-requirements.txt. build-requirements.txt contains the hashes of the wheels on the production pypi mirror. In order to get this PR passing, you will need to build the production wheels and submit a PR to securedrop-debian-packaging that contains the new wheels.

requests==2.22.0
urllib3==1.25.10

The "Updating Python Wheels" section in https://github.com/freedomofpress/securedrop-debian-packaging/blob/main/README.md is a good place to start, which will walk you through creating a pull request to securedrop-debian-packaging repo with the new wheels. Once the wheels built and committed, you can use the wheel hash in this pr in the build-requirements.txt requirements file.

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zenmonkeykstop, LGTM!

@emkll emkll merged commit 9fef2d8 into main Oct 8, 2020
@emkll emkll deleted the safety-update-urllib3 branch October 8, 2020 21:21
@emkll emkll mentioned this pull request Nov 3, 2020
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants