-
Notifications
You must be signed in to change notification settings - Fork 6
Adds setup.py and other details for packaging #10
Conversation
include requirements.txt | ||
include README.md | ||
include LICENSE | ||
include setup.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove this since it's redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make the python file inclusion explicit.
incoming.append(line) | ||
incoming = "\n".join(incoming) | ||
|
||
main.__main__(incoming, p) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we want two commits that:
git mv sd-proxy.py
intosecuredrop_proxy/entrypoint.py
? (git mv
to preserve git history)- create
start
function (to make the changes clear)
otherwise we'll have two versions of this that are basically the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking to remove sd-proxy.py
in a next commit :)
include *.py | ||
include requirements.txt | ||
include README.md | ||
include LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have this file yet in the repo btw
Adds a console entry point to use the `sd-proxy` command. It also adds the LICENSE file for the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we talked about in person, I think we should update the README to reflect how to use the packaging changes (really just a link to https://securedrop-debian-packaging-guide.readthedocs.io/en/latest/pythondevels.html), and probably redo to the "integrating with Qubes" section in the README, too, but otherwise this looks great.
This includes a
sd-proxy
command using console entry_points.Closes #10
Closes #4