Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Adds setup.py and other details for packaging #10

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Sep 27, 2018

This includes a sd-proxy command using console entry_points.

Closes #10
Closes #4

include requirements.txt
include README.md
include LICENSE
include setup.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this since it's redundant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the python file inclusion explicit.

incoming.append(line)
incoming = "\n".join(incoming)

main.__main__(incoming, p)
Copy link
Contributor

@redshiftzero redshiftzero Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want two commits that:

  1. git mv sd-proxy.py into securedrop_proxy/entrypoint.py? (git mv to preserve git history)
  2. create start function (to make the changes clear)

otherwise we'll have two versions of this that are basically the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to remove sd-proxy.py in a next commit :)

include *.py
include requirements.txt
include README.md
include LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have this file yet in the repo btw

Adds a console entry point to use the `sd-proxy` command.
It also adds the LICENSE file for the project
Copy link
Contributor

@joshuathayer joshuathayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked about in person, I think we should update the README to reflect how to use the packaging changes (really just a link to https://securedrop-debian-packaging-guide.readthedocs.io/en/latest/pythondevels.html), and probably redo to the "integrating with Qubes" section in the README, too, but otherwise this looks great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants