Update index.html and automate the process #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
- Verify that the updated links in
index.htmlresolve to valid files that are currently deployed on https://securedrop.org/https-everywhere/ - As a throwaway change, update the
latest-rulesets-timestampfile with a random new timestamp, and attempt to updateindex.htmlusing./update_index.sh.
Looks great. These changes are mostly oriented toward humans viewing the rules in a browser. Clients were successfully loading the changes introduced by #7. As such, no signing changes are part of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
index.htmlwas not updated in #7, so https://securedrop.org/https-everywhere/ still links to the old version of the ruleset. This PR updates it, and also provides a little shell script to automate this step in future.Test plan
index.htmlresolve to valid files that are currently deployed on https://securedrop.org/https-everywhere/latest-rulesets-timestampfile with a random new timestamp, and attempt to updateindex.htmlusing./update_index.sh.