Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for external 2021 path in the nginx redirect #62

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

maeve-fpf
Copy link
Contributor

Status

With the changes in #59 to handle //, it doesn't really make sense to try to handle trailing slash redirects over in ingress-nginx. Let's have the internal static-file nginx be responsible, and configure it to know its external URL.

This is all kind of a mess because we're translating /https-everywhere-2021 on the outside to /https-everywhere in here. I'm putting this right into the nginx.conf on the assumption that this URL is temporary and we will get rid of it pretty soon. But if we should add some sort of runtime configuration, I can look into that.

Review Checklist

N/A - Visual review and see next section

Post-Deployment Checklist

A curl of http://staging.securedrop.org/https-everywhere-2021 should return location: http://staging.securedrop.org/https-everywhere-2021/.

Copy link

@echoesactiii echoesactiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as described for me!

@maeve-fpf maeve-fpf merged commit 343a298 into key-rotation-2021 Jul 1, 2021
@legoktm legoktm deleted the key-rotation-redirect-fix branch June 10, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants