Account for external 2021 path in the nginx redirect #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
With the changes in #59 to handle
//
, it doesn't really make sense to try to handle trailing slash redirects over in ingress-nginx. Let's have the internal static-file nginx be responsible, and configure it to know its external URL.This is all kind of a mess because we're translating
/https-everywhere-2021
on the outside to/https-everywhere
in here. I'm putting this right into the nginx.conf on the assumption that this URL is temporary and we will get rid of it pretty soon. But if we should add some sort of runtime configuration, I can look into that.Review Checklist
N/A - Visual review and see next section
Post-Deployment Checklist
A curl of
http://staging.securedrop.org/https-everywhere-2021
should returnlocation: http://staging.securedrop.org/https-everywhere-2021/
.