-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports addition of Forbidden Stories #58
Conversation
(cherry picked from commit 060948a)
nginx changes look good! If it's at all helpful, I rebased |
43602e0
to
8153b38
Compare
Tried this out in the latest alpha, rule changes show up - if @eloquence or someone else can take a look it would be good to get it merged on the off-chance the alpha period goes really quickly :) |
I've got an alpha ready, will give it a spin. |
Starting with the GitHub URL, of course I'm hitting the issue again where all onion names break after I change the Path Prefix - though "rulesets version" correctly set to |
OK, after troubleshooting with Kev, determined that the trick appears to be to wait a fairly significant time (up to ~1 minute) after adding the Path Prefix before trying an onion name again - the resolution of the ruleset date does not indicate that it's ready to use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good once it actually loaded.
Status
Ready for review:
Signed with 2021 key, currently only supported by TBB Alpha
Review Checklist
onboarded.txt
are accuratedefault.rulesets.TIMESTAMP.gz
has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rulesPath Prefix
:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME
index.html
has been updated using./update_index.sh
Post-Deployment Checklist