This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
pushed a commit
to freedomofpress/securedrop-apt-test
that referenced
this pull request
Oct 15, 2020
Removes mimetype associations, incorporating changes from PR freedomofpress/securedrop-export#65
conorsch
pushed a commit
to freedomofpress/securedrop-builder
that referenced
this pull request
Oct 16, 2020
Bumps version 0.2.3 -> 0.2.4, see matching changes in: freedomofpress/securedrop-export#65
3 tasks
Changes here look good to me , and good to merge after dropping the temporary commit |
As part of template consolidation [0], we're moving mimetype associations out of system volumes and into private volumes. Therefore we no longer need these files in the 'securedrop-export' package, as the corresponding files have already been ported to 'securedrop-workstation-config'. [0] freedomofpress/securedrop-workstation#471
conorsch
force-pushed
the
remove-mimetype-handlers
branch
from
October 22, 2020 17:21
7508ce0
to
3376f0b
Compare
Rebased to include #64 |
30 tasks
conorsch
force-pushed
the
remove-mimetype-handlers
branch
from
October 27, 2020 19:54
3376f0b
to
34a8cf6
Compare
Dropped temporary commit. That means CI will fail here until freedomofpress/securedrop-builder#198 is merged, so let's get that one in first, then re-run CI here to confirm everything's green. |
conorsch
pushed a commit
to freedomofpress/securedrop-builder
that referenced
this pull request
Oct 27, 2020
See matching changes in: freedomofpress/securedrop-export#65
emkll
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of template consolidation [0], we're moving mimetype
associations out of system volumes and into private volumes. Therefore
we no longer need these files in the 'securedrop-export' package, as the
corresponding files have already been ported to
'securedrop-workstation-config'.
[0] freedomofpress/securedrop-workstation#471
Packaging changes are in freedomofpress/securedrop-builder#198