Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Removes mimetype associations #65

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Removes mimetype associations #65

merged 1 commit into from
Oct 27, 2020

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Oct 15, 2020

As part of template consolidation [0], we're moving mimetype
associations out of system volumes and into private volumes. Therefore
we no longer need these files in the 'securedrop-export' package, as the
corresponding files have already been ported to
'securedrop-workstation-config'.

[0] freedomofpress/securedrop-workstation#471

Packaging changes are in freedomofpress/securedrop-builder#198

conorsch pushed a commit to freedomofpress/securedrop-apt-test that referenced this pull request Oct 15, 2020
Removes mimetype associations, incorporating changes from PR

freedomofpress/securedrop-export#65
conorsch pushed a commit to freedomofpress/securedrop-builder that referenced this pull request Oct 16, 2020
Bumps version 0.2.3 -> 0.2.4, see matching changes in:

freedomofpress/securedrop-export#65
@zenmonkeykstop zenmonkeykstop self-assigned this Oct 19, 2020
@emkll
Copy link
Contributor

emkll commented Oct 22, 2020

Changes here look good to me , and good to merge after dropping the temporary commit

As part of template consolidation [0], we're moving mimetype
associations out of system volumes and into private volumes. Therefore
we no longer need these files in the 'securedrop-export' package, as the
corresponding files have already been ported to
'securedrop-workstation-config'.

[0] freedomofpress/securedrop-workstation#471
@conorsch conorsch force-pushed the remove-mimetype-handlers branch from 7508ce0 to 3376f0b Compare October 22, 2020 17:21
@conorsch
Copy link
Contributor Author

Rebased to include #64

@conorsch
Copy link
Contributor Author

Dropped temporary commit. That means CI will fail here until freedomofpress/securedrop-builder#198 is merged, so let's get that one in first, then re-run CI here to confirm everything's green.

@conorsch conorsch marked this pull request as ready for review October 27, 2020 19:55
conorsch pushed a commit to freedomofpress/securedrop-builder that referenced this pull request Oct 27, 2020
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emkll emkll merged commit 0d93075 into main Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants