-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
3ed91d4
to
7fd001e
Compare
i think the build-buster test failing is expected for now but i can't remember why... will look into this tomorrow |
@emkll - I see that this causes a regression where it's sending ERROR_GENERIC back when no printer is connected instead of PRINTER_NOT_FOUND so please hold off on reviewing until I switch it from |
2afd493
to
0f5f401
Compare
the build test is failing due to the following error reported freedomofpress/securedrop-client#699 the error message is:
|
0f5f401
to
144abce
Compare
The failing test might work after this fix: #50 Also, the latest commit was to fix rebase errors from export refactor. |
bd60687
to
315153c
Compare
315153c
to
d3bd8ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff looks good and I manually tested the no printer case and the printing happy path. For multiple printers, I only have one supported printer to test, however based on visual review of the diff this logic lgtm.
Description
ERROR_MULTIPLE_PRINTERS_FOUND
.Test