This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Add logging to securedrop-export #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
reviewed
Sep 27, 2019
securedrop_export/entrypoint.py
Outdated
| configure_logging() | ||
| except Exception: | ||
| msg = "ERROR_LOGGING" | ||
| my_sub.exit_gracefully(msg) |
There was a problem hiding this comment.
Careful: my_sub isn't defined at this point, so the exit_gracefully call will raise an exception of its own. flake8 catches this mistake, but we don't run flake8 in CI for this repo—perhaps we should add it. Would be simple enough to copy/paste from e.g. https://github.com/freedomofpress/securedrop-workstation/blob/bbebfc0f0f1fd45bab7956e3d9d4412c434532ca/Makefile#L127-L133
emkll
force-pushed
the
add-logging
branch
2 times, most recently
from
ccaf9b3 to
a3c998c
Compare
|
lgtm! I see the expected error logs and some useful info logs. This will come in handy when working on printer support too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Status
Ready for review
Test Plan
Build and functionally test
python3 setup.py sdistmasterbranch of securedrop-debian-packaging repo (adjacent to this package)PKG_VERSION=0.1.2 PKG_PATH=../securedrop-export/dist/securedrop-export-0.1.2.tar.gz make securedrop-exportVisual review
Keeping in mind this information will be lost on each reboot, as it will be logged in
sd-export-usb, a named DispVM that should last for an entire workstation session