Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.8.2->2.0.0 update guide; bump version #232

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Add 1.8.2->2.0.0 update guide; bump version #232

merged 4 commits into from
Jun 23, 2021

Conversation

eloquence
Copy link
Member

Status

Ready for review, in draft state to merge on day of release

Description of Changes

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

@@ -1,19 +1,18 @@
Upgrade from 1.7.0 to 1.7.1
Upgrade from 1.8.2 to 2.0.0
Copy link
Member Author

@eloquence eloquence Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is git's move detection being off and treating a new file as a rename/edit. :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split into its own commit as fae248d to aid diff readability.

@rocodes rocodes self-requested a review June 17, 2021 18:43
@rocodes
Copy link
Contributor

rocodes commented Jun 17, 2021

Have reviewed (it's still in draft mode), LGTM with one or two small suggestions:

  • If a user is on Tails 4.14 or earlier, I think we should just advise them to manually upgrade. I wonder if it's worth calling that case out specifically or not.

  • Maybe we should include an explicit nod to Xenial stragglers in the Updating Servers section? "If your instance is running Ubuntu 16.04, your SI has been disabled and you will not receive this update. Contact us for assistance."

  • (out of scope just mentioning) We should maybe consider updating the "Getting Support" text to clarify that, if you run a SecureDrop instance, you should sign up for an account on the support portal, rather than filing issues on the community forum (as the wording sort of suggests). But I can do that in another PR.

@eloquence
Copy link
Member Author

eloquence commented Jun 17, 2021

Thanks @rocodes for the review!

Maybe we should include an explicit nod to Xenial stragglers in the Updating Servers section?

Done.

If a user is on Tails 4.14 or earlier, I think we should just advise them to manually upgrade.

I still had a Tails 4.2 drive, so I just tested the workaround in this PR. It triggered an automatic update to 4.19 as expected, so I think as long as folks are at least on the Tails 4 series, we can recommend they run the one-liner.

We should maybe consider updating the "Getting Support" text

Agree, a separate PR for that would be awesome - thanks for flagging. :)

Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @eloquence for preparing.

@eloquence eloquence marked this pull request as ready for review June 23, 2021 22:45
@eloquence eloquence merged commit 3877932 into main Jun 23, 2021
@legoktm legoktm deleted the 182-to-200 branch May 28, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants