-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Admin USB rebuild instructions for v3 + 20.04 instances #224
Conversation
Comments for reviewer:
|
One early observation: The instructions for single-user mode may need to be updated. At least on my NUC10s with Ubuntu 20.04:
@rocodes would you like to consider that in the scope of this PR, or would you prefer if I file a separate issue for it? |
8c913bb
to
a5a6392
Compare
Thanks for your review! I've addressed your comments in a5a6392. I didn't provide updated instructions for getting into the GRUB menu because it does vary based on hardware model and I think it's fair to expect admins to figure that part out themselves if need be, but I did update the line about the kernelopts in single user mode. |
I stepped through a full rebuild using these docs and while I encountered a couple of stumbles (I specified the wrong IP to I may push some minor tweaks but otherwise I think this looks pretty good to go. |
This looks good from my end! @zenmonkeykstop, it would be great if you could have a look. I think a visual review & input on overall structure and open comments is probably sufficient; I tested the overall process (except for the HTTPS configuration -- I only tested that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't attempted a run-thru yet, but I think this needs some changes to address the fact that authentication keys will change. At minimum all existing keys need to be reprovisioned (this wasn't the case for v2 because the hidden service auth token didn't change).
(update: more work tk on this on Monday) |
Update single-user-mode instructions to include current kernelopts, note GRUB menu access differs by hardware.
…e ip instead of nnetplan file for network info.
90668bb
to
33f6c42
Compare
(Starting another round of review on this today, may not get all the way through until tomorrow.) |
I stepped through the whole process one more time and I think this is good to go. Thanks for all your hard work on this, @rocodes. I hit one snag: When running |
…s has been reconfigured.
Also trims whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rocodes! As per our discussion last week, I've not re-tested whether the SSH-over-LAN setting resolves the reboot issue during the playbook run, but logically it makes sense to me, and I trust in your own test results. @zenmonkeykstop, I believe your previous review comments were all addressed - I think this is good to merge.
Note I've appended one small commit to clarify the implications of the SSH-over-Tor vs. SSH-over-LAN setting.
Thanks a lot for the hard work on this, glad to be getting these updated docs in.
Status
Ready for review
Description of Changes
Description: Update Admin rebuild instructions for use with Focal / v3 onions
Fixes Instructions for rebuilding Admin Workstation are not applicable for v3 #138
Testing
Release
Checklist (Optional)
make docs-lint
) passed locallymake docs-linkcheck
) passed - error on unrelated link (https://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html), appears to be ssl-relatedmake docs
) docs at http://localhost:8000