Removes VirtualBox references throughout docs #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as blocked for now, since I based these changes on #214 |
|
(Can be rebased now that #214 is merged.) |
Supplements freedomofpress/securedrop#5922. Edits the dev docs to remove explicit mentions of Virtualbox, preferring Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS docs. For macOS, we're now more clearly directing folks to use the container dev env.
conorsch
force-pushed
the
remove-virtualbox-docs
branch
from
3f8ec6d to
b5a3e8e
Compare
|
Rebased, and removed "blocked" label, since #214 is in. Ready for review. |
sssoleileraaa
force-pushed
the
remove-virtualbox-docs
branch
from
71799b9 to
813e650
Compare
Signed-off-by: Allie Crevier <[email protected]>
sssoleileraaa
force-pushed
the
remove-virtualbox-docs
branch
from
813e650 to
9e9b886
Compare
sssoleileraaa
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Supplements freedomofpress/securedrop#5922. Edits the dev docs to remove explicit mentions of Virtualbox, preferring Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS docs. For macOS, we're now more clearly directing folks to use the container dev env.
Testing
Release
No concerns, these changes are dev-only.
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000