-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Xenial-specific references from the docs #214
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,7 +89,6 @@ Run ``make help`` to see the full list of CI commands in the Makefile: | |
Makefile for developing and testing SecureDrop. | ||
Subcommands: | ||
ci-go Creates, provisions, tests, and destroys GCE host for testing staging environment. | ||
ci-go-xenial Creates, provisions, tests, and destroys GCE host for testing staging environment under xenial. | ||
ci-lint Runs linting in linting container. | ||
ci-teardown Destroys GCE host for testing staging environment. | ||
|
||
|
@@ -117,48 +116,48 @@ of a commit to apply to a branch in order disable the deletion for the Focal sta | |
|
||
.. code:: Diff | ||
|
||
diff --git a/.circleci/config.yml b/.circleci/config.yml | ||
index 4a9b0bd4c..d9aea01b8 100644 | ||
--- a/.circleci/config.yml | ||
+++ b/.circleci/config.yml | ||
@@ -354,13 +354,6 @@ jobs: | ||
BASE_OS=focal make ci-go | ||
no_output_timeout: 35m | ||
|
||
- - run: | ||
- name: Ensure environment torn down | ||
- # Always report true, since env should will destroyed already | ||
- # if all tests passed. | ||
- command: make ci-teardown || true | ||
- when: always | ||
- | ||
- store_test_results: | ||
path: ~/sd/junit | ||
|
||
diff --git a/devops/gce-nested/ci-go.sh b/devops/gce-nested/ci-go.sh | ||
index 850324ecc..776120df4 100755 | ||
--- a/devops/gce-nested/ci-go.sh | ||
+++ b/devops/gce-nested/ci-go.sh | ||
@@ -16,4 +16,3 @@ export BASE_OS="${BASE_OS:-xenial}" | ||
diff --git a/.circleci/config.yml b/.circleci/config.yml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tested that diff applies cleanly on current |
||
index 4d61769f1..af74672bc 100644 | ||
--- a/.circleci/config.yml | ||
+++ b/.circleci/config.yml | ||
@@ -251,13 +251,6 @@ jobs: | ||
make ci-go | ||
no_output_timeout: 35m | ||
|
||
- - run: | ||
- name: Ensure environment torn down | ||
- # Always report true, since env should will destroyed already | ||
- # if all tests passed. | ||
- command: make ci-teardown || true | ||
- when: always | ||
- | ||
- store_test_results: | ||
path: ~/sd/junit | ||
|
||
diff --git a/devops/gce-nested/ci-go.sh b/devops/gce-nested/ci-go.sh | ||
index ff80aa107..65bbcd7b9 100755 | ||
--- a/devops/gce-nested/ci-go.sh | ||
+++ b/devops/gce-nested/ci-go.sh | ||
@@ -16,4 +16,3 @@ export BASE_OS="${BASE_OS:-focal}" | ||
|
||
./devops/gce-nested/gce-start.sh | ||
./devops/gce-nested/gce-runner.sh | ||
-./devops/gce-nested/gce-stop.sh | ||
diff --git a/devops/scripts/create-staging-env b/devops/scripts/create-staging-env | ||
index 3b9a2c7f8..df2ccfe3d 100755 | ||
--- a/devops/scripts/create-staging-env | ||
+++ b/devops/scripts/create-staging-env | ||
@@ -33,7 +33,7 @@ printf "Creating staging environment via '%s'...\\n" "${securedrop_staging_scena | ||
-./devops/gce-nested/gce-stop.sh | ||
diff --git a/devops/scripts/create-staging-env b/devops/scripts/create-staging-env | ||
index 8b296be94..df8a4d674 100755 | ||
--- a/devops/scripts/create-staging-env | ||
+++ b/devops/scripts/create-staging-env | ||
@@ -32,7 +32,7 @@ printf "Creating staging environment via '%s'...\\n" "${securedrop_staging_scena | ||
virtualenv_bootstrap | ||
# Are we in CI? Then lets do full testing post install! | ||
if [ "$USER" = "sdci" ]; then | ||
- molecule test -s "${securedrop_staging_scenario}" | ||
+ molecule test --destroy=never -s "${securedrop_staging_scenario}" | ||
- molecule test -s "${securedrop_staging_scenario}" | ||
+ molecule test --destroy=never -s "${securedrop_staging_scenario}" | ||
else | ||
molecule "${MOLECULE_ACTION:-converge}" -s "${securedrop_staging_scenario}" "${EXTRA_ANSIBLE_ARGS[@]}" | ||
molecule "${MOLECULE_ACTION:-converge}" -s "${securedrop_staging_scenario}" "${EXTRA_ANSIBLE_ARGS[@]}" | ||
fi | ||
|
||
Once that commit is pushed, run the appropriate ``staging-test-with-rebase`` job | ||
Once that commit is pushed, run the ``staging-test-with-rebase`` job | ||
with ssh using with CircleCI. Once logged into that container, you can ssh into the | ||
Google Compute host: | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think by 2.10 or 2.2.0 we can remove the OS platform check here from the docs entirely, but fine to keep for now to avoid any confusion.