Update the i18n release management workflow #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
suggested changes
Mar 16, 2021
|
I added links to the two repos, along with repeated explanations of the relationship. Let me know what you think of the remaining issues, and whether you're still seeing that |
sssoleileraaa
previously approved these changes
Mar 17, 2021
|
@rmol would you like to rebase and fixup the "address review" commit? or shall i squash and merge? |
Our current i18n release management workflow gets everything right on the securedrop-i18n/i18n branch, but doesn't ensure that the PO template is updated back on the develop branch. This change adds the step of running "make translate" on the develop branch and getting that PR merged before merging develop to the i18n fork.
rmol
force-pushed
the
update-i18n-release-management-workflow
branch
from
653e29b to
6901ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Our current i18n release management workflow gets everything right on the
securedrop-i18n/i18nbranch, but doesn't ensure that the PO template is updated back on thedevelopbranch. This change adds the step of runningmake translateon thedevelopbranch and getting that PR merged before mergingdevelopto the i18n fork.Testing
Release
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000