Expand OSSEC documentation based on @emkll's old commits #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloquence
changed the title
|
Thanks @joaedwar for adding these. I took a pass through this and clarified some original language, and appended a commit to your branch. I think this is ready for a final review/merge. |
eloquence
previously requested changes
Dec 3, 2020
emkll
force-pushed
the
ossec_alerts_reuse
branch
2 times, most recently
from
c677528 to
4152932
Compare
|
Good catch @eloquence , I've restored the next that was lost in the port and addressed your comments, and rebased on latest |
rmol
suggested changes
Dec 10, 2020
emkll
force-pushed
the
ossec_alerts_reuse
branch
from
4152932 to
f457fa2
Compare
|
thanks @rmol for the review, your comments should have been addressed in the latest revision |
rmol
suggested changes
Dec 17, 2020
and restore deleted entries.
emkll
force-pushed
the
ossec_alerts_reuse
branch
from
f457fa2 to
529e744
Compare
rmol
dismissed
eloquence’s stale review
I believe all of the points have been addressed.
rmol
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Description: OSSEC alerts original commits by emkil. Taken from this commit
freedomofpress/securedrop@ff97d47#diff-14415a526de4a3de45c9c26a38a256f894278ca66c6c4fb52589884b182b96f9
Fixes Documentation about OSSEC alert levels #69
Testing
Release
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000