SecureDrop core packages for 1.4.0-rc1 #44
Conversation
There was a problem hiding this comment.
Based on the build logs, it appears the packages including here are built on the commit immediately following the 1.3.0 release (when 1.4.0-rc1 was updated) freedomofpress/securedrop@148392a
I would have expected, that the packages be built on (or close to) the following commit hash, which includes changes introduced after 1.3.0:
freedomofpress/securedrop@efd1121
conorsch
force-pushed
the
securedrop-1.4.0-rc1
branch
from
5139f26 to
25ada24
Compare
|
You're absolutely correct, @emkll, the packages were built from the wrong commit. Resolved and rebuilt.
Ready for re-review. |
There was a problem hiding this comment.
✔️ confirmed https://github.com/freedomofpress/securedrop/releases/tag/1.4.0-rc1 points to the expected changelog commit: freedomofpress/securedrop@efd1121
✔️ confirmed deb checksums match build logs (see inline comments at the end of this diff: freedomofpress/build-logs@76c5242)
redshiftzero
dismissed
emkll’s stale review
Dismissing, review comments have been addressed. Thanks emkll
Status
Ready for review
Towards freedomofpress/securedrop#5289
Build logs available here: freedomofpress/build-logs@dd2aade
Description of changes
Debian packages for 1.4.0-rc1. Note that builder security updates check is failing due to out-of-date image. The builder image has not yet been updated accordingly, but should be before rc2.
Checklist