Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Rust toolchain upgrade process and goals #79

Closed
legoktm opened this issue Jul 13, 2023 · 0 comments · Fixed by #84
Closed

Document Rust toolchain upgrade process and goals #79

legoktm opened this issue Jul 13, 2023 · 0 comments · Fixed by #84
Assignees

Comments

@legoktm
Copy link
Member

legoktm commented Jul 13, 2023

Describe the change

We're responsible for keeping the Rust toolchain up to date, so we should have some rough guidelines and instructions.

I think we should aim to stay 2-3 versions within the latest release, with a 6-week release cycle that would have us updating roughly every 3-5 months (of course we can update faster if there's features we want or specific needs).

Not sure we need to specify the list of files to update since that could change (and hopefully we de-duplicate later on), but for completeness it's:

rust-toolchain.toml
2:channel = "1.69.0"

builder/Dockerfile
45:ENV RUST_VERSION 1.69.0

securedrop/dockerfiles/focal/python3/SlimDockerfile
18:ENV RUST_VERSION 1.69.0

.circleci/config.yml
100:      - image: rust:1.69.0

(maybe we add some magic string like RUST_VERSION everywhere to make it easy to grep for)

Test plan can be based off of freedomofpress/securedrop#6832

@legoktm legoktm self-assigned this Aug 3, 2023
legoktm added a commit that referenced this issue Aug 3, 2023
We're responsible for keeping the Rust toolchain up to date, so add some
rough guidelines and instructions.

The test plan is based off of
<freedomofpress/securedrop#6832>.

Fixes #79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant