Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the login modal, thus ensuring only one instance is possible at once. #978

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Mar 23, 2020

Description

Fixes #971.

Making the login widget modal is the ideal solution since this is precisely the use case for such modal dialogs. Let Qt do the work for you. ;-)

Test Plan

Please check with Eyeball Mk1. 👀 Feedback from @ninavizz and @eloquence on possible UI change of behaviour.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

@redshiftzero
Copy link
Contributor

thanks!

@redshiftzero redshiftzero merged commit 7220944 into freedomofpress:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on Login multiple times opens multiple windows
2 participants